Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error when resuming training with Apex #14341

Merged
merged 14 commits into from
Aug 26, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 22, 2022

What does this PR do?

Alternative approach to #12389

Fixes #11488

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @justusschock @carmocca @awaelchli @akihironitta @rohitgr7

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 22, 2022
@awaelchli awaelchli changed the title x Fix reloading apex amp state Aug 22, 2022
@awaelchli awaelchli added bug Something isn't working precision: apex (removed) NVIDIA/apex precision labels Aug 22, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Aug 22, 2022
@awaelchli awaelchli added the breaking change Includes a breaking change label Aug 22, 2022
@awaelchli awaelchli self-assigned this Aug 22, 2022
@awaelchli awaelchli changed the title Fix reloading apex amp state Raise an error when resuming training with Apex Aug 22, 2022
@awaelchli awaelchli marked this pull request as ready for review August 22, 2022 12:55
tests/tests_pytorch/models/test_amp.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Aug 22, 2022
@awaelchli awaelchli enabled auto-merge (squash) August 23, 2022 10:02
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 26, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 26, 2022
@awaelchli awaelchli merged commit e2221a0 into master Aug 26, 2022
@awaelchli awaelchli deleted the bugfix/amp-reload branch August 26, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change bug Something isn't working pl Generic label for PyTorch Lightning package precision: apex (removed) NVIDIA/apex precision ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Unable to resume from checkpoint when using apex
4 participants