Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save checkpoints and profiler output to the first logger #14325

Merged
merged 8 commits into from
Aug 26, 2022
Merged

save checkpoints and profiler output to the first logger #14325

merged 8 commits into from
Aug 26, 2022

Conversation

tshu-w
Copy link
Contributor

@tshu-w tshu-w commented Aug 20, 2022

What does this PR do?

Fixes #12177 save checkpoints and profiler output to the first logger, which is a blocker of #14188.

Does your PR introduce any breaking changes? If yes, please list them.

Yes, as discussed in #12177.

I also delete pytorch_lightning.utilities.logger._name directly without marking them as deprecated since it is not used in another place and it doesn't break an API.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 20, 2022
@tshu-w tshu-w marked this pull request as draft August 20, 2022 09:04
@tshu-w tshu-w marked this pull request as ready for review August 20, 2022 11:27
@awaelchli awaelchli added feature Is an improvement or enhancement logger Related to the Loggers breaking change Includes a breaking change labels Aug 20, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Aug 20, 2022
tests/tests_pytorch/profilers/test_profiler.py Outdated Show resolved Hide resolved
src/pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Aug 22, 2022
src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
@tshu-w tshu-w requested a review from awaelchli August 23, 2022 11:42
@awaelchli awaelchli requested a review from rohitgr7 August 23, 2022 15:33
@awaelchli awaelchli enabled auto-merge (squash) August 26, 2022 12:42
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #14325 (14b398d) into master (70fe0ed) will decrease coverage by 3%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #14325      +/-   ##
==========================================
- Coverage      79%      76%      -3%     
==========================================
  Files         111      332     +221     
  Lines        7258    26920   +19662     
==========================================
+ Hits         5740    20449   +14709     
- Misses       1518     6471    +4953     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change feature Is an improvement or enhancement logger Related to the Loggers pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
5 participants