-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save checkpoints and profiler output to the first logger #14325
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshu-w
requested review from
williamFalcon,
tchaton,
awaelchli,
Borda,
carmocca,
kaushikb11,
justusschock,
rohitgr7 and
otaj
as code owners
August 20, 2022 08:58
awaelchli
added
feature
Is an improvement or enhancement
logger
Related to the Loggers
breaking change
Includes a breaking change
labels
Aug 20, 2022
awaelchli
approved these changes
Aug 20, 2022
rohitgr7
reviewed
Aug 21, 2022
rohitgr7
reviewed
Aug 21, 2022
tshu-w
requested review from
edenlightning and
Felonious-Spellfire
as code owners
August 22, 2022 01:31
rohitgr7
approved these changes
Aug 22, 2022
awaelchli
approved these changes
Aug 22, 2022
carmocca
approved these changes
Aug 22, 2022
Co-authored-by: Adrian Wälchli <[email protected]>
Borda
approved these changes
Aug 26, 2022
Codecov Report
@@ Coverage Diff @@
## master #14325 +/- ##
==========================================
- Coverage 79% 76% -3%
==========================================
Files 111 332 +221
Lines 7258 26920 +19662
==========================================
+ Hits 5740 20449 +14709
- Misses 1518 6471 +4953 |
12 tasks
This was referenced Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
feature
Is an improvement or enhancement
logger
Related to the Loggers
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12177 save checkpoints and profiler output to the first logger, which is a blocker of #14188.
Does your PR introduce any breaking changes? If yes, please list them.
Yes, as discussed in #12177.
I also delete
pytorch_lightning.utilities.logger._name
directly without marking them as deprecated since it is not used in another place and it doesn't break an API.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃