Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto wrapping for DDPFullyShardedNativeStrategy #14252

Merged
merged 20 commits into from
Aug 26, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Aug 17, 2022

What does this PR do?

The PR resolves the note here: https://pytorch-lightning.readthedocs.io/en/latest/advanced/model_parallel.html?highlight=deepspeed#pytorch-fully-sharded-training

now users don't have to use wrap every time to shard the layers if they are switching to fully sharded.
I will do this to fairscale in a follow-up.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@rohitgr7 rohitgr7 self-assigned this Aug 17, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 17, 2022
@rohitgr7 rohitgr7 added feature Is an improvement or enhancement strategy: fsdp Fully Sharded Data Parallel labels Aug 18, 2022
@rohitgr7 rohitgr7 added this to the pl:1.8 milestone Aug 18, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review August 18, 2022 11:43
@mergify mergify bot removed the has conflicts label Aug 18, 2022
@rohitgr7 rohitgr7 requested a review from otaj as a code owner August 21, 2022 20:19
@rohitgr7 rohitgr7 requested a review from carmocca August 21, 2022 20:19
@mergify mergify bot added the ready PRs ready to be merged label Aug 22, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) August 22, 2022 15:16
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #14252 (38f9bc8) into master (e67842d) will decrease coverage by 3%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master   #14252      +/-   ##
==========================================
- Coverage      79%      76%      -3%     
==========================================
  Files         111      332     +221     
  Lines        7258    26919   +19661     
==========================================
+ Hits         5740    20446   +14706     
- Misses       1518     6473    +4955     

@rohitgr7 rohitgr7 merged commit 6d00f31 into master Aug 26, 2022
@rohitgr7 rohitgr7 deleted the feat/auto_wrap_pt_fsdp branch August 26, 2022 09:01
@rohitgr7 rohitgr7 mentioned this pull request Sep 9, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: fsdp Fully Sharded Data Parallel
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants