-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto wrapping for DDPFullyShardedNativeStrategy
#14252
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
added
feature
Is an improvement or enhancement
strategy: fsdp
Fully Sharded Data Parallel
labels
Aug 18, 2022
rohitgr7
requested review from
tchaton,
awaelchli,
justusschock,
kaushikb11,
carmocca,
edenlightning,
Borda,
Felonious-Spellfire and
williamFalcon
as code owners
August 18, 2022 11:43
awaelchli
suggested changes
Aug 18, 2022
awaelchli
approved these changes
Aug 19, 2022
carmocca
reviewed
Aug 19, 2022
tests/tests_pytorch/strategies/test_ddp_fully_sharded_native.py
Outdated
Show resolved
Hide resolved
carmocca
approved these changes
Aug 22, 2022
12 tasks
justusschock
approved these changes
Aug 26, 2022
Codecov Report
@@ Coverage Diff @@
## master #14252 +/- ##
==========================================
- Coverage 79% 76% -3%
==========================================
Files 111 332 +221
Lines 7258 26919 +19661
==========================================
+ Hits 5740 20446 +14706
- Misses 1518 6473 +4955 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Is an improvement or enhancement
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
strategy: fsdp
Fully Sharded Data Parallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR resolves the note here: https://pytorch-lightning.readthedocs.io/en/latest/advanced/model_parallel.html?highlight=deepspeed#pytorch-fully-sharded-training
now users don't have to use
wrap
every time to shard the layers if they are switching to fully sharded.I will do this to fairscale in a follow-up.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda