Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate on_colab_kaggle func #14247

Merged
merged 5 commits into from
Aug 18, 2022
Merged

Deprecate on_colab_kaggle func #14247

merged 5 commits into from
Aug 18, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Aug 17, 2022

What does this PR do?

See title. This is not being used anywhere now.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7

@rohitgr7 rohitgr7 added the deprecation Includes a deprecation label Aug 17, 2022
@rohitgr7 rohitgr7 added this to the pl:1.8 milestone Aug 17, 2022
@rohitgr7 rohitgr7 self-assigned this Aug 17, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 17, 2022
@rohitgr7 rohitgr7 requested a review from carmocca as a code owner August 17, 2022 12:55
src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Aug 18, 2022
@awaelchli awaelchli enabled auto-merge (squash) August 18, 2022 10:28
@awaelchli awaelchli merged commit d9c6090 into master Aug 18, 2022
@awaelchli awaelchli deleted the dep/on_colab_kaggle branch August 18, 2022 18:34
nicolai86 pushed a commit that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants