Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type check for non-standard schedulers in horovod #14215

Merged
merged 7 commits into from
Aug 18, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 15, 2022

What does this PR do?

Fixes #14236

Fixes a typing assertion error being caused when using a special scheduler like ReduceOnPlateau with horovod.
Discovered in a question on stackoverflow.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @awaelchli

@awaelchli awaelchli added bug Something isn't working strategy: horovod (removed) labels Aug 15, 2022
@awaelchli awaelchli added this to the pl:1.7.x milestone Aug 15, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 15, 2022
@awaelchli awaelchli self-assigned this Aug 15, 2022
@awaelchli awaelchli marked this pull request as ready for review August 15, 2022 23:22
@mergify mergify bot added the ready PRs ready to be merged label Aug 16, 2022
@mergify mergify bot requested a review from a team August 16, 2022 17:48
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 17, 2022
@awaelchli awaelchli enabled auto-merge (squash) August 17, 2022 20:36
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #14215 (ac7c846) into master (52051c5) will decrease coverage by 3%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #14215      +/-   ##
==========================================
- Coverage      79%      76%      -3%     
==========================================
  Files         109      330     +221     
  Lines        7149    26760   +19611     
==========================================
+ Hits         5662    20342   +14680     
- Misses       1487     6418    +4931     

Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 18, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 18, 2022
@awaelchli awaelchli merged commit 047f0aa into master Aug 18, 2022
@awaelchli awaelchli deleted the bugfix/horovod-reduce branch August 18, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: horovod (removed)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ReduceLROnPlateau with horovod
5 participants