Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward extra keyword arguments in LightningDataModule.from_datasets #14185

Merged
merged 8 commits into from
Aug 18, 2022
Merged

Forward extra keyword arguments in LightningDataModule.from_datasets #14185

merged 8 commits into from
Aug 18, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 12, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Closes #14082

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @carmocca @awaelchli @ananthsub @ninginthecloud @jjenniferdai @rohitgr7 @akihironitta

@awaelchli awaelchli added feature Is an improvement or enhancement lightningdatamodule pl.LightningDataModule labels Aug 12, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 12, 2022
@awaelchli awaelchli self-assigned this Aug 12, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Aug 12, 2022
@awaelchli awaelchli marked this pull request as ready for review August 12, 2022 13:22
@awaelchli awaelchli mentioned this pull request Aug 12, 2022
Closed
12 tasks
krshrimali
krshrimali approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @awaelchli! 🚀

tests/tests_pytorch/core/test_datamodules.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Aug 12, 2022
@awaelchli awaelchli requested a review from carmocca August 18, 2022 09:57
@otaj otaj enabled auto-merge (squash) August 18, 2022 11:59
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #14185 (08a9d75) into master (8ab65ff) will decrease coverage by 3%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #14185      +/-   ##
==========================================
- Coverage      79%      76%      -3%     
==========================================
  Files         109      330     +221     
  Lines        7149    26769   +19620     
==========================================
+ Hits         5662    20351   +14689     
- Misses       1487     6418    +4931

@otaj otaj merged commit 326f756 into master Aug 18, 2022
@otaj otaj deleted the bugfix/from-datasets branch August 18, 2022 14:06
nicolai86 pushed a commit that referenced this pull request Aug 23, 2022
@awaelchli @carmocca @nicolai86
Forward extra keyword arguments in LightningDataModule.from_datasets (
b3ad05c 
#14185)

Co-authored-by: otaj <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
@krshrimali krshrimali mentioned this pull request Sep 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@otaj otaj otaj left review comments

@krshrimali krshrimali krshrimali approved these changes

@carmocca carmocca carmocca approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@ananthsub ananthsub Awaiting requested review from ananthsub

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@awaelchli awaelchli

Labels
feature Is an improvement or enhancement lightningdatamodule pl.LightningDataModule pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@awaelchli @otaj @carmocca @krshrimali @rohitgr7