-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(app): Add load_state_dict and state_dict #14100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Aug 8, 2022
tchaton
changed the title
PoC: Add state_dict and load_state_dict
PoC: Add Aug 9, 2022
on_load_state_dict
and on_save_state_dict
tchaton
changed the title
PoC: Add
(app): Add on_load_state_dict and on_save_state_dict
Aug 9, 2022
on_load_state_dict
and on_save_state_dict
manskx
reviewed
Aug 9, 2022
manskx
reviewed
Aug 9, 2022
manskx
reviewed
Aug 9, 2022
manskx
approved these changes
Aug 9, 2022
awaelchli
reviewed
Aug 10, 2022
lantiga
reviewed
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments on capturing a "resumable state" from Work.
tchaton
force-pushed
the
on_load_checkpoint
branch
from
August 10, 2022 14:22
2deac5a
to
7c50a5f
Compare
tchaton
force-pushed
the
on_load_checkpoint
branch
from
August 10, 2022 14:25
fe8e2f6
to
bff2986
Compare
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Aug 18, 2022
@tchaton, mind checking the remaining comments? |
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces an API to reload dynamic component trees.
The current strategy is the following. We collect all the states. On reload, if a component state doesn't have its component, we give the responsibility to its closest parent to resolve it and then the cascade of instantiation is done.
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda