-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix seed_everything log messages with rank info #14031
Merged
carmocca
merged 15 commits into
Lightning-AI:master
from
MrShevan:prefix_rank_to_seed_everything
Aug 9, 2022
Merged
Prefix seed_everything log messages with rank info #14031
carmocca
merged 15 commits into
Lightning-AI:master
from
MrShevan:prefix_rank_to_seed_everything
Aug 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
MrShevan
requested review from
Borda,
tchaton,
carmocca,
williamFalcon,
awaelchli,
justusschock,
kaushikb11 and
rohitgr7
as code owners
August 5, 2022 06:01
Codecov Report
@@ Coverage Diff @@
## master #14031 +/- ##
=========================================
+ Coverage 61% 76% +15%
=========================================
Files 324 324
Lines 26384 26423 +39
=========================================
+ Hits 16169 20150 +3981
+ Misses 10215 6273 -3942 |
awaelchli
reviewed
Aug 5, 2022
@carmocca, hi! Could you review this? |
awaelchli
reviewed
Aug 8, 2022
awaelchli
approved these changes
Aug 8, 2022
otaj
approved these changes
Aug 9, 2022
kaushikb11
approved these changes
Aug 9, 2022
rohitgr7
approved these changes
Aug 9, 2022
Co-authored-by: Rohit Gupta <[email protected]>
carmocca
reviewed
Aug 9, 2022
carmocca
approved these changes
Aug 9, 2022
jessecambon
pushed a commit
to jessecambon/lightning
that referenced
this pull request
Aug 16, 2022
Co-authored-by: Anton Shevtsov <[email protected]> Co-authored-by: Rohit Gupta <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
distributed
Generic distributed-related topic
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13290
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃