Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix seed_everything log messages with rank info #14031

Merged
merged 15 commits into from
Aug 9, 2022

Conversation

MrShevan
Copy link
Contributor

@MrShevan MrShevan commented Aug 4, 2022

What does this PR do?

Fixes #13290

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 4, 2022
@MrShevan MrShevan marked this pull request as ready for review August 5, 2022 06:01
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #14031 (cc16e33) into master (b25275c) will increase coverage by 15%.
The diff coverage is 100%.

❗ Current head cc16e33 differs from pull request most recent head 5c25c76. Consider uploading reports for the commit 5c25c76 to get more accurate results

@@            Coverage Diff            @@
##           master   #14031     +/-   ##
=========================================
+ Coverage      61%      76%    +15%     
=========================================
  Files         324      324             
  Lines       26384    26423     +39     
=========================================
+ Hits        16169    20150   +3981     
+ Misses      10215     6273   -3942     

@MrShevan
Copy link
Contributor Author

MrShevan commented Aug 8, 2022

@carmocca, hi! Could you review this?

src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
src/pytorch_lightning/utilities/seed.py Outdated Show resolved Hide resolved
@Borda Borda added this to the pl:1.7.x milestone Aug 8, 2022
@awaelchli awaelchli added the distributed Generic distributed-related topic label Aug 8, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 9, 2022
tests/tests_pytorch/utilities/test_seed.py Outdated Show resolved Hide resolved
@carmocca carmocca merged commit c55fe71 into Lightning-AI:master Aug 9, 2022
@awaelchli awaelchli modified the milestones: pl:1.7.x, pl:1.8 Aug 9, 2022
jessecambon pushed a commit to jessecambon/lightning that referenced this pull request Aug 16, 2022
Co-authored-by: Anton Shevtsov <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Generic distributed-related topic pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Prefix seed_everything log messages with rank info
7 participants