Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated DDP2 strategy #14026

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Remove the deprecated DDP2 strategy #14026

merged 4 commits into from
Aug 4, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Aug 4, 2022

What does this PR do?

See title

Does your PR introduce any breaking changes? If yes, please list them.

Removes deprecated code

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @justusschock @awaelchli @rohitgr7 @akihironitta

@carmocca carmocca added refactor strategy: ddp2 pl Generic label for PyTorch Lightning package labels Aug 4, 2022
@carmocca carmocca added this to the pl:1.8 milestone Aug 4, 2022
@carmocca carmocca self-assigned this Aug 4, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #14026 (8258942) into master (ef0623e) will decrease coverage by 4%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #14026      +/-   ##
==========================================
- Coverage      80%      76%      -4%     
==========================================
  Files         103      323     +220     
  Lines        6843    26505   +19662     
==========================================
+ Hits         5451    20140   +14689     
- Misses       1392     6365    +4973     

@carmocca carmocca enabled auto-merge (squash) August 4, 2022 20:00
@carmocca carmocca merged commit b88b700 into master Aug 4, 2022
@carmocca carmocca deleted the refactor/ddp2-removal branch August 4, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants