Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable on_before_batch_transfer for DPStrategy and IPUAccelerator #14023

Merged
merged 10 commits into from
Aug 18, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Aug 4, 2022

What does this PR do?

Call to on_before_batch_transfer shouldn't be limited to whether any strategy/accelerator supports explicit transfer to batches to the device. Users should still be able to use this for batch transforms, etc...

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • x ] Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @awaelchli @ninginthecloud @rohitgr7 @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 4, 2022
@rohitgr7 rohitgr7 changed the title on_before_batch_transfer hook out of _apply_batch_transfer_handler and enable it for DPStrategy and IPUAccelerator Enable on_before_batch_transfer for DPStrategy and IPUAccelerator Aug 4, 2022
@rohitgr7 rohitgr7 self-assigned this Aug 4, 2022
@rohitgr7 rohitgr7 added this to the pl:1.8 milestone Aug 4, 2022
@rohitgr7 rohitgr7 added feature Is an improvement or enhancement hooks Related to the hooks API labels Aug 4, 2022
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accept to unblock, but I disagree with it the same way I disagreed when the on_before and on_after hooks were originally introduced.

on_before_batch_transfer has no meaning when the transfer is handled internally by the accelerator.

docs/source-pytorch/accelerators/ipu_basic.rst Outdated Show resolved Hide resolved
@rohitgr7
Copy link
Contributor Author

Accept to unblock, but I disagree with it the same way I disagreed when the on_before and on_after hooks were originally introduced.

on_before_batch_transfer has no meaning when the transfer is handled internally by the accelerator.

we can probably remove them if you have better recommendations here on how users can perform batch transformations on/off device?

@rohitgr7 rohitgr7 requested a review from awaelchli August 13, 2022 09:00
src/pytorch_lightning/core/module.py Outdated Show resolved Hide resolved
src/pytorch_lightning/core/module.py Outdated Show resolved Hide resolved
src/pytorch_lightning/loops/dataloader/evaluation_loop.py Outdated Show resolved Hide resolved
src/pytorch_lightning/loops/dataloader/evaluation_loop.py Outdated Show resolved Hide resolved
src/pytorch_lightning/loops/fit_loop.py Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 requested a review from carmocca August 17, 2022 14:35
@mergify mergify bot added the ready PRs ready to be merged label Aug 17, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) August 17, 2022 15:09
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 17, 2022
@rohitgr7 rohitgr7 disabled auto-merge August 18, 2022 11:26
@rohitgr7 rohitgr7 enabled auto-merge (squash) August 18, 2022 11:26
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 18, 2022
@rohitgr7 rohitgr7 merged commit e949362 into master Aug 18, 2022
@rohitgr7 rohitgr7 deleted the ref/obbt branch August 18, 2022 12:12
nicolai86 pushed a commit that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement hooks Related to the hooks API pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants