Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast to fp16 before moving to device with deepspeed #14000

Merged
merged 10 commits into from
Aug 5, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Aug 3, 2022

What does this PR do?

Blue: master
Orange: PR
Screenshot 2022-08-03 at 6 12 32 PM

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7 @awaelchli @akihironitta @carmocca @justusschock

@rohitgr7 rohitgr7 added bug Something isn't working deprecation Includes a deprecation strategy: deepspeed precision: apex (removed) NVIDIA/apex precision labels Aug 3, 2022
@rohitgr7 rohitgr7 added this to the pl:1.8 milestone Aug 3, 2022
@rohitgr7 rohitgr7 self-assigned this Aug 3, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 3, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review August 3, 2022 18:01
@carmocca
Copy link
Contributor

carmocca commented Aug 4, 2022

IMO this should be part of a bug-fix release

@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Aug 4, 2022

IMO this should be part of a bug-fix release

Then, should I move out the deprecated module from here in a sep PR or just say.. deprecated in 1.7.1 and will be removed in 1.9?

@carmocca
Copy link
Contributor

carmocca commented Aug 4, 2022

I would choose the "deprecated in 1.7.1" option, but the other would also be fine.

src/pytorch_lightning/strategies/ipu.py Outdated Show resolved Hide resolved
src/pytorch_lightning/strategies/deepspeed.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Aug 4, 2022
@rohitgr7 rohitgr7 modified the milestones: pl:1.8, pl:1.7.x Aug 4, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #14000 (e97dc32) into master (91dd6a6) will increase coverage by 15%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##           master   #14000     +/-   ##
=========================================
+ Coverage      61%      76%    +15%     
=========================================
  Files         323      323             
  Lines       26319    26366     +47     
=========================================
+ Hits        16107    20126   +4019     
+ Misses      10212     6240   -3972     

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 5, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 5, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 5, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 5, 2022
@awaelchli awaelchli enabled auto-merge (squash) August 5, 2022 21:55
@awaelchli awaelchli merged commit b25275c into master Aug 5, 2022
@awaelchli awaelchli deleted the bug/deepspeed_cast branch August 5, 2022 22:15
awaelchli added a commit that referenced this pull request Aug 9, 2022
awaelchli added a commit that referenced this pull request Aug 9, 2022
awaelchli added a commit that referenced this pull request Aug 9, 2022
lexierule pushed a commit that referenced this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deprecation Includes a deprecation pl Generic label for PyTorch Lightning package precision: apex (removed) NVIDIA/apex precision ready PRs ready to be merged strategy: deepspeed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants