-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cast to fp16 before moving to device with deepspeed #14000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
added
bug
Something isn't working
deprecation
Includes a deprecation
strategy: deepspeed
precision: apex (removed)
NVIDIA/apex precision
labels
Aug 3, 2022
rohitgr7
requested review from
tchaton,
awaelchli,
justusschock,
kaushikb11,
williamFalcon,
Borda and
carmocca
as code owners
August 3, 2022 18:01
carmocca
approved these changes
Aug 4, 2022
IMO this should be part of a bug-fix release |
Then, should I move out the deprecated module from here in a sep PR or just say.. deprecated in 1.7.1 and will be removed in 1.9? |
I would choose the "deprecated in 1.7.1" option, but the other would also be fine. |
justusschock
approved these changes
Aug 4, 2022
Codecov Report
@@ Coverage Diff @@
## master #14000 +/- ##
=========================================
+ Coverage 61% 76% +15%
=========================================
Files 323 323
Lines 26319 26366 +47
=========================================
+ Hits 16107 20126 +4019
+ Misses 10212 6240 -3972 |
carmocca
reviewed
Aug 5, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Aug 5, 2022
12 tasks
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Aug 5, 2022
kaushikb11
approved these changes
Aug 5, 2022
awaelchli
reviewed
Aug 5, 2022
awaelchli
approved these changes
Aug 5, 2022
awaelchli
added a commit
that referenced
this pull request
Aug 9, 2022
Co-authored-by: rohitgr7 <[email protected]>
awaelchli
added a commit
that referenced
this pull request
Aug 9, 2022
Co-authored-by: Rohit Gupta <[email protected]>
awaelchli
added a commit
that referenced
this pull request
Aug 9, 2022
Co-authored-by: Rohit Gupta <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Aug 9, 2022
Co-authored-by: Rohit Gupta <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
deprecation
Includes a deprecation
pl
Generic label for PyTorch Lightning package
precision: apex (removed)
NVIDIA/apex precision
ready
PRs ready to be merged
strategy: deepspeed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Blue: master
Orange: PR
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @tchaton @rohitgr7 @awaelchli @akihironitta @carmocca @justusschock