Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tbptt imports Python 3.10 compatible #13973

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 2, 2022

What does this PR do?

collections.Sequence got moved to collections.abc.Sequence in Python 3.10.
This fixes the code paths for TBPTT when running in Python 3.10.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 2, 2022
@awaelchli awaelchli added bug Something isn't working and removed pl Generic label for PyTorch Lightning package labels Aug 2, 2022
@awaelchli awaelchli added this to the pl:1.7.x milestone Aug 2, 2022
@awaelchli awaelchli marked this pull request as ready for review August 2, 2022 01:21
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #13973 (e86b081) into master (eb233ea) will not change coverage.
The diff coverage is 67%.

@@           Coverage Diff           @@
##           master   #13973   +/-   ##
=======================================
  Coverage      76%      76%           
=======================================
  Files         335      335           
  Lines       26368    26368           
=======================================
  Hits        20137    20137           
  Misses       6231     6231           

@mergify mergify bot added the ready PRs ready to be merged label Aug 2, 2022
@justusschock justusschock enabled auto-merge (squash) August 2, 2022 08:35
@justusschock justusschock merged commit 0fbfbf9 into master Aug 2, 2022
@justusschock justusschock deleted the bugfix/python310-Sequence branch August 2, 2022 08:55
@awaelchli awaelchli modified the milestones: pl:1.7.x, pl:1.7 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants