Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue to avoid the impact of sanity check on reload_dataloaders_every_n_epochs for validation #13964

Merged
merged 16 commits into from
Aug 21, 2022
Merged

Fix an issue to avoid the impact of sanity check on reload_dataloaders_every_n_epochs for validation #13964

merged 16 commits into from
Aug 21, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Aug 1, 2022 •
edited by github-actions bot
Loading

What does this PR do?

sanity_check was affecting the dataloader reload conditions for validation since we use the same dataloaders for validation too.

Found when working on #12145
This doesn't fix it because the behavior of reload_dataloaders_every_n_epoch is different for train and val.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃 (painful)

cc @Borda @justusschock @awaelchli @ninginthecloud @rohitgr7 @otaj @akihironitta

@rohitgr7 rohitgr7 added bug Something isn't working data handling Generic data-related topic labels Aug 1, 2022
@rohitgr7 rohitgr7 added this to the pl:1.7.x milestone Aug 1, 2022
@rohitgr7 rohitgr7 self-assigned this Aug 1, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 1, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review August 1, 2022 14:03
@rohitgr7 rohitgr7 requested a review from awaelchli August 6, 2022 19:10
@codecov
Copy link

codecov bot commented Aug 6, 2022 •
edited
Loading

Codecov Report

Merging #13964 (6fabf98) into master (527b28e) will increase coverage by 15%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #13964     +/-   ##
=========================================
+ Coverage      61%      76%    +15%     
=========================================
  Files         326      329      +3     
  Lines       26565    26705    +140     
=========================================
+ Hits        16233    20287   +4054     
+ Misses      10332     6418   -3914

@mergify mergify bot added the has conflicts label Aug 8, 2022
@rohitgr7 rohitgr7 changed the title Fix val dataloader reload conditions when check_val_every_n_epochs is set Fixed an issue to avoid the impact of sanity check on reload_dataloaders_every_n_epochs for validatio Aug 10, 2022
@rohitgr7 rohitgr7 changed the title Fixed an issue to avoid the impact of sanity check on reload_dataloaders_every_n_epochs for validatio Fix an issue to avoid the impact of sanity check on reload_dataloaders_every_n_epochs for validatio Aug 10, 2022
@rohitgr7 rohitgr7 changed the title Fix an issue to avoid the impact of sanity check on reload_dataloaders_every_n_epochs for validatio Fix an issue to avoid the impact of sanity check on reload_dataloaders_every_n_epochs for validation Aug 10, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review August 10, 2022 17:18
@mergify mergify bot removed the has conflicts label Aug 10, 2022
rohitgr7
rohitgr7 commented Aug 11, 2022
View reviewed changes
src/pytorch_lightning/loops/dataloader/prediction_loop.py Show resolved Hide resolved
src/pytorch_lightning/loops/epoch/prediction_epoch_loop.py Show resolved Hide resolved
src/pytorch_lightning/loops/fit_loop.py Show resolved Hide resolved
src/pytorch_lightning/trainer/connectors/data_connector.py Show resolved Hide resolved
src/pytorch_lightning/trainer/connectors/data_connector.py Show resolved Hide resolved
src/pytorch_lightning/trainer/trainer.py Show resolved Hide resolved
src/pytorch_lightning/trainer/trainer.py Show resolved Hide resolved
src/pytorch_lightning/trainer/trainer.py Show resolved Hide resolved
tests/tests_pytorch/trainer/test_dataloaders.py Show resolved Hide resolved
tests/tests_pytorch/trainer/test_dataloaders.py Show resolved Hide resolved
@rohitgr7 rohitgr7 requested a review from awaelchli August 11, 2022 14:13
@awaelchli awaelchli modified the milestones: pl:1.7.x, pl:1.8 Aug 12, 2022
@mergify mergify bot removed the has conflicts label Aug 18, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 19, 2022
@rohitgr7 rohitgr7 merged commit db1835a into master Aug 21, 2022
@rohitgr7 rohitgr7 deleted the bug/val_reload branch August 21, 2022 18:25
rohitgr7 added a commit that referenced this pull request Aug 23, 2022
@rohitgr7
Fix an issue to avoid the impact of sanity check on `reload_dataloade…
654c401 
…rs_every_n_epochs` for validation (#13964)
nicolai86 pushed a commit that referenced this pull request Aug 23, 2022
@rohitgr7 @nicolai86
Fix an issue to avoid the impact of sanity check on `reload_dataloade…
d9dd4b4 
…rs_every_n_epochs` for validation (#13964)
lexierule pushed a commit that referenced this pull request Aug 25, 2022
@rohitgr7 @lexierule
Fix an issue to avoid the impact of sanity check on `reload_dataloade…
cb8b3f4 
…rs_every_n_epochs` for validation (#13964)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@rohitgr7 rohitgr7

Labels
bug Something isn't working data handling Generic data-related topic pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
pl:1.7.x
Development

Successfully merging this pull request may close these issues.
3 participants
@rohitgr7 @awaelchli @carmocca