Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error if batch transfer hooks are overridden with IPUAccelerator #13961

Merged
merged 5 commits into from
Aug 4, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Aug 1, 2022

What does this PR do?

Fixes #13916

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @akihironitta

@rohitgr7 rohitgr7 added bug Something isn't working accelerator: ipu (removed) Intelligence Processing Unit breaking change Includes a breaking change labels Aug 1, 2022
@rohitgr7 rohitgr7 added this to the pl:1.7.x milestone Aug 1, 2022
@rohitgr7 rohitgr7 self-assigned this Aug 1, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 1, 2022
tests/tests_pytorch/trainer/test_config_validator.py Outdated Show resolved Hide resolved
docs/source-pytorch/accelerators/gpu_intermediate.rst Outdated Show resolved Hide resolved
docs/source-pytorch/accelerators/ipu_basic.rst Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Aug 1, 2022
@carmocca carmocca removed the bug Something isn't working label Aug 3, 2022
@carmocca carmocca modified the milestones: pl:1.7.x, pl:1.8 Aug 3, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 4, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) August 4, 2022 11:05
@rohitgr7 rohitgr7 merged commit e78bf20 into master Aug 4, 2022
@rohitgr7 rohitgr7 deleted the ref/ipu_batch_transfer branch August 4, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: ipu (removed) Intelligence Processing Unit breaking change Includes a breaking change pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn IPU users that batch transfering hooks will not run
4 participants