Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate amp_level from Trainer #13898

Merged
merged 8 commits into from
Aug 5, 2022
Merged

Deprecate amp_level from Trainer #13898

merged 8 commits into from
Aug 5, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jul 28, 2022

What does this PR do?

Fixes #12655

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @tchaton @rohitgr7 @carmocca @justusschock @awaelchli @akihironitta @kaushikb11 @Borda

@rohitgr7 rohitgr7 added deprecation Includes a deprecation trainer: argument labels Jul 28, 2022
@rohitgr7 rohitgr7 added this to the pl:1.8 milestone Jul 28, 2022
@rohitgr7 rohitgr7 self-assigned this Jul 28, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 28, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #13898 (565bada) into master (332182d) will increase coverage by 15%.
The diff coverage is 100%.

❗ Current head 565bada differs from pull request most recent head 8065f5c. Consider uploading reports for the commit 8065f5c to get more accurate results

@@            Coverage Diff            @@
##           master   #13898     +/-   ##
=========================================
+ Coverage      61%      76%    +15%     
=========================================
  Files         341      341             
  Lines       26596    26608     +12     
=========================================
+ Hits        16211    20247   +4036     
+ Misses      10385     6361   -4024     

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the removal version

@carmocca carmocca added the precision: apex (removed) NVIDIA/apex precision label Aug 4, 2022
src/pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Aug 4, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rohitgr7 rohitgr7 enabled auto-merge (squash) August 5, 2022 07:52
@rohitgr7 rohitgr7 merged commit a4e4cab into master Aug 5, 2022
@rohitgr7 rohitgr7 deleted the dep/amp_level branch August 5, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation pl Generic label for PyTorch Lightning package precision: apex (removed) NVIDIA/apex precision ready PRs ready to be merged trainer: argument
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Deprecate amp_level in favour of ApexMixedPrecisionPlugin(amp_level=...)
4 participants