-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deepspeed default precision plugin amp_level
to O2
#13897
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
added
bug
Something isn't working
strategy: deepspeed
precision: apex (removed)
NVIDIA/apex precision
labels
Jul 28, 2022
rohitgr7
changed the title
Fix deepspeed default precision plugin to O2
Fix deepspeed default precision plugin Jul 28, 2022
amp_level
to O2
rohitgr7
requested review from
tchaton,
carmocca,
Borda,
awaelchli,
justusschock,
williamFalcon and
kaushikb11
as code owners
July 28, 2022 09:48
kaushikb11
reviewed
Jul 28, 2022
kaushikb11
approved these changes
Jul 28, 2022
awaelchli
reviewed
Jul 28, 2022
src/pytorch_lightning/trainer/connectors/accelerator_connector.py
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #13897 +/- ##
=========================================
+ Coverage 61% 76% +15%
=========================================
Files 335 333 -2
Lines 26301 26163 -138
=========================================
+ Hits 16048 19980 +3932
+ Misses 10253 6183 -4070 |
awaelchli
approved these changes
Jul 28, 2022
carmocca
approved these changes
Jul 28, 2022
akihironitta
approved these changes
Jul 28, 2022
src/pytorch_lightning/trainer/connectors/accelerator_connector.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Akihiro Nitta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
pl
Generic label for PyTorch Lightning package
precision: apex (removed)
NVIDIA/apex precision
ready
PRs ready to be merged
strategy: deepspeed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With
This error was raised:
RuntimeError: Unexpected optimization level None. Options are 'O0', 'O1', 'O2', 'O3'. Note that in `O0`, `O1`, etc., the prefix O is the letter O, not the number zero.
But as per docs, default should be
O2
.Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @awaelchli @rohitgr7 @akihironitta @carmocca @justusschock