Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the model input of trainer methods #13892

Merged
merged 9 commits into from
Aug 3, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 27, 2022

What does this PR do?

Fixes #13355
Partially addresses #13981

When passing something other than a LightningModule to the Trainer, we currently get a misleading error message that doesn't help the user find the issue. Now I'm adding a check to all the Trainer methods that need a LightningModule.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @justusschock @kaushikb11 @awaelchli @ananthsub @ninginthecloud @jjenniferdai @rohitgr7 @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 27, 2022
@awaelchli awaelchli added this to the pl:1.6.x milestone Jul 27, 2022
@awaelchli awaelchli added the feature Is an improvement or enhancement label Jul 27, 2022
@awaelchli awaelchli modified the milestones: pl:1.6.x, pl:1.8 Jul 27, 2022
@awaelchli awaelchli marked this pull request as ready for review July 27, 2022 19:42
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #13892 (b0e6906) into master (9651e42) will increase coverage by 15%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #13892     +/-   ##
=========================================
+ Coverage      61%      76%    +15%     
=========================================
  Files         341      341             
  Lines       26523    26575     +52     
=========================================
+ Hits        16184    20230   +4046     
+ Misses      10339     6345   -3994     

@mergify mergify bot added the ready PRs ready to be merged label Jul 28, 2022
src/pytorch_lightning/trainer/trainer.py Show resolved Hide resolved
src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
src/pytorch_lightning/trainer/trainer.py Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli enabled auto-merge (squash) August 3, 2022 08:23
@awaelchli awaelchli merged commit 4ce97f3 into master Aug 3, 2022
@awaelchli awaelchli deleted the bugfix/trainer-method-error branch August 3, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged trainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Unwrapping the module did not yield a LightningModule
7 participants