-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate the model input of trainer methods #13892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…o bugfix/trainer-method-error
awaelchli
requested review from
williamFalcon,
tchaton,
Borda,
carmocca,
justusschock,
kaushikb11 and
rohitgr7
as code owners
July 27, 2022 19:42
Codecov Report
@@ Coverage Diff @@
## master #13892 +/- ##
=========================================
+ Coverage 61% 76% +15%
=========================================
Files 341 341
Lines 26523 26575 +52
=========================================
+ Hits 16184 20230 +4046
+ Misses 10339 6345 -3994 |
carmocca
approved these changes
Jul 27, 2022
kaushikb11
approved these changes
Jul 28, 2022
rohitgr7
approved these changes
Jul 28, 2022
Co-authored-by: Rohit Gupta <[email protected]>
akihironitta
approved these changes
Aug 1, 2022
tchaton
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
for more information, see https://pre-commit.ci
otaj
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13355
Partially addresses #13981
When passing something other than a LightningModule to the Trainer, we currently get a misleading error message that doesn't help the user find the issue. Now I'm adding a check to all the Trainer methods that need a LightningModule.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @justusschock @kaushikb11 @awaelchli @ananthsub @ninginthecloud @jjenniferdai @rohitgr7 @akihironitta