-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove meta device utilities in favor of torchdistx #13868
Conversation
Converting to draft while I address the dependency issues |
Since this is all very experimental, I decided not to add the dependency. It's very tricky choosing the ABI version dynamically. And it's only released with PyTorch 1.12 compatibility. |
Codecov Report
@@ Coverage Diff @@
## master #13868 +/- ##
==========================================
- Coverage 80% 76% -3%
==========================================
Files 103 323 +220
Lines 6858 26356 +19498
==========================================
+ Hits 5462 20116 +14654
- Misses 1396 6240 +4844 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
See https://github.com/pytorch/torchdistx
Fixes #13796
Fixes #13660
Closes #13763
Does your PR introduce any breaking changes? If yes, please list them.
Removes the experimental code for meta tensor materialization.
Before submitting
PR review
cc @Borda @justusschock @awaelchli @rohitgr7 @tchaton @akihironitta