-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow batch sampler with multiple IPU devices #13854
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaj
added
bug
Something isn't working
breaking change
Includes a breaking change
strategy: ipu (removed)
labels
Jul 26, 2022
otaj
requested review from
Borda,
tchaton,
carmocca,
awaelchli,
justusschock,
kaushikb11,
edenlightning,
Felonious-Spellfire,
williamFalcon and
rohitgr7
as code owners
July 26, 2022 15:39
carmocca
approved these changes
Jul 26, 2022
Borda
approved these changes
Jul 26, 2022
Codecov Report
@@ Coverage Diff @@
## master #13854 +/- ##
=========================================
+ Coverage 49% 76% +27%
=========================================
Files 332 332
Lines 26000 26054 +54
=========================================
+ Hits 12728 19812 +7084
+ Misses 13272 6242 -7030 |
rohitgr7
approved these changes
Jul 27, 2022
Co-authored-by: Rohit Gupta <[email protected]>
kaushikb11
approved these changes
Jul 27, 2022
awaelchli
reviewed
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
bug
Something isn't working
data handling
Generic data-related topic
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
strategy: ipu (removed)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When running on multiple IPUs,
poptorch.DataLoader
increases batch size, which is not compatible withbatch_sampler
argument at all. This was discovered during debugging of #13640Does your PR introduce any breaking changes? If yes, please list them.
It is impossible to have a
BatchSampler
in while running on multiple IPUs. This never worked, however the user did not get an error message about it, but some different one, later on. Now the attempt to have explicitBatchSampler
fails.Note that users can still pass
batch_size
argument, which creates a defaultBatchSampler
under the hood and this still worksBefore submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @justusschock @awaelchli @ninginthecloud @rohitgr7 @otaj @Borda @akihironitta