-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset epoch progress with batch size scaler #13846
Merged
rohitgr7
merged 15 commits into
Lightning-AI:master
from
cschell:bugfix/13696_fix_batch_size_tuner
Aug 26, 2022
Merged
Reset epoch progress with batch size scaler #13846
rohitgr7
merged 15 commits into
Lightning-AI:master
from
cschell:bugfix/13696_fix_batch_size_tuner
Aug 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschell
requested review from
SkafteNicki,
Borda,
awaelchli,
williamFalcon,
tchaton,
carmocca,
justusschock,
kaushikb11 and
rohitgr7
as code owners
July 26, 2022 08:56
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #13846 +/- ##
==========================================
- Coverage 79% 76% -3%
==========================================
Files 111 332 +221
Lines 7258 26909 +19651
==========================================
+ Hits 5740 20450 +14710
- Misses 1518 6459 +4941 |
rohitgr7
reviewed
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be fixed by #11089, but test could help :)
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
rohitgr7
approved these changes
Aug 22, 2022
rohitgr7
changed the title
Fix auto batch tuner
Reset epoch progress with batch size scaler
Aug 22, 2022
carmocca
approved these changes
Aug 23, 2022
carmocca
reviewed
Aug 23, 2022
awaelchli
approved these changes
Aug 24, 2022
justusschock
approved these changes
Aug 24, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Aug 26, 2022
rohitgr7
added a commit
that referenced
this pull request
Aug 27, 2022
Co-authored-by: Christian Schell <[email protected]> Co-authored-by: Rohit Gupta <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Aug 31, 2022
Co-authored-by: Christian Schell <[email protected]> Co-authored-by: Rohit Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
_run_binsearch_scaling
and_run_power_scaling
don't have to know about the Trainer internals. However, it seems to work fine for now, and since there is a test now for that particular issue, any breaking changes should at least get noticed.Fixes #13696
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
🦦