Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling in learning rate finder #13845

Merged
merged 11 commits into from
Jul 27, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 26, 2022

What does this PR do?

Fixes #13844

  1. Proper error message and handling of boundaries
  2. No longer set the learning rate attribute to None if failing to make a valid LR suggestion

The added tests cover these cases and fail on master.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @akihironitta @Borda @rohitgr7

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 26, 2022
@awaelchli awaelchli added bug Something isn't working tuner and removed pl Generic label for PyTorch Lightning package labels Jul 26, 2022
@awaelchli awaelchli added this to the pl:1.6.x milestone Jul 26, 2022
@awaelchli awaelchli changed the title Improve error handling in learning rate finder Fix error handling in learning rate finder Jul 26, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 26, 2022
@awaelchli awaelchli marked this pull request as ready for review July 26, 2022 06:12
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #13845 (a083dde) into master (4c35867) will increase coverage by 27%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #13845     +/-   ##
=========================================
+ Coverage      49%      76%    +27%     
=========================================
  Files         330      330             
  Lines       25897    26227    +330     
=========================================
+ Hits        12688    19861   +7173     
+ Misses      13209     6366   -6843     

src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jul 26, 2022
@awaelchli awaelchli merged commit c391170 into master Jul 27, 2022
@awaelchli awaelchli deleted the bugfix/lr-suggestion branch July 27, 2022 08:32
@awaelchli awaelchli modified the milestones: pl:1.6.x, pl:1.7 Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pl Generic label for PyTorch Lightning package ready PRs ready to be merged tuner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling for learning rate finder suggestion
4 participants