Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote the CLI out of utilities #13767

Merged
merged 13 commits into from
Jul 23, 2022
Merged

Promote the CLI out of utilities #13767

merged 13 commits into from
Jul 23, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jul 20, 2022

What does this PR do?

Fixes #13737

This PR is will not use "Rebase and Merge" because we aren't moving all the code together. Some deprecated pieces will stay in the old module.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @justusschock @awaelchli @rohitgr7 @tchaton @carmocca @mauvilsa

@carmocca carmocca added refactor deprecation Includes a deprecation lightningcli pl.cli.LightningCLI labels Jul 20, 2022
@carmocca carmocca self-assigned this Jul 20, 2022
@carmocca carmocca added this to the pl:1.7 milestone Jul 20, 2022
@carmocca carmocca force-pushed the refactor/promote-cli branch from 30efcca to 10ac9a1 Compare July 20, 2022 19:57
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #13767 (c8a13de) into master (9f51c07) will increase coverage by 0%.
The diff coverage is 98%.

@@           Coverage Diff           @@
##           master   #13767   +/-   ##
=======================================
  Coverage      86%      86%           
=======================================
  Files         327      328    +1     
  Lines       25564    25589   +25     
=======================================
+ Hits        21966    21997   +31     
+ Misses       3598     3592    -6     

@carmocca carmocca enabled auto-merge (squash) July 20, 2022 22:39
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 21, 2022
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!
didn't see that registry is still there in the utilities.

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 22, 2022
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts ready PRs ready to be merged labels Jul 22, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 22, 2022
@carmocca carmocca merged commit 4f53e71 into master Jul 23, 2022
@carmocca carmocca deleted the refactor/promote-cli branch July 23, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation lightningcli pl.cli.LightningCLI ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote the LightningCLI out of utilities
7 participants