-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote the CLI out of utilities #13767
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
added
refactor
deprecation
Includes a deprecation
lightningcli
pl.cli.LightningCLI
labels
Jul 20, 2022
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
carmocca
requested review from
tchaton,
awaelchli,
manskx,
hhsecond,
Borda,
SeanNaren,
edenlightning,
Felonious-Spellfire,
williamFalcon,
justusschock,
kaushikb11 and
rohitgr7
as code owners
July 20, 2022 19:08
carmocca
force-pushed
the
refactor/promote-cli
branch
from
July 20, 2022 19:57
30efcca
to
10ac9a1
Compare
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #13767 +/- ##
=======================================
Coverage 86% 86%
=======================================
Files 327 328 +1
Lines 25564 25589 +25
=======================================
+ Hits 21966 21997 +31
+ Misses 3598 3592 -6 |
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Jul 21, 2022
rohitgr7
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!
didn't see that registry is still there in the utilities.
otaj
approved these changes
Jul 22, 2022
awaelchli
approved these changes
Jul 22, 2022
Borda
approved these changes
Jul 22, 2022
mergify
bot
added
ready
PRs ready to be merged
has conflicts
and removed
has conflicts
ready
PRs ready to be merged
labels
Jul 22, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Jul 22, 2022
This was referenced Aug 6, 2022
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deprecation
Includes a deprecation
lightningcli
pl.cli.LightningCLI
ready
PRs ready to be merged
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13737
This PR is will not use "Rebase and Merge" because we aren't moving all the code together. Some deprecated pieces will stay in the old module.
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
cc @Borda @justusschock @awaelchli @rohitgr7 @tchaton @carmocca @mauvilsa