Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GPUAccelerator to CUDAAccelerator #13636

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Conversation

justusschock
Copy link
Member

@justusschock justusschock commented Jul 13, 2022

What does this PR do?

As discussed in #13102 this renames the current GPUAccelerator to CUDAAccelerator.
Introduces strategy='cuda' but retains strategy='gpu' for this PR temporarily

In a follow-up, I will re-route accelerator='gpu' to support cuda and mps devices (as also discussed in #13102 )

Does your PR introduce any breaking changes? If yes, please list them.

Yes, deprecates the current GPU Accelerator

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7 @tchaton @kaushikb11 @akihironitta

@justusschock justusschock self-assigned this Jul 13, 2022
@justusschock justusschock added refactor accelerator: cuda Compute Unified Device Architecture GPU labels Jul 13, 2022
@justusschock justusschock added this to the pl:1.7 milestone Jul 13, 2022
@justusschock justusschock force-pushed the reroute_gpu_accelerator branch from 68ef8c7 to 3e58f9b Compare July 14, 2022 08:40
@carmocca carmocca added the deprecation Includes a deprecation label Jul 18, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Should we preserve the git history with "rebase&merge"? (If we do, will need to clean up the commits)

@mergify mergify bot added the ready PRs ready to be merged label Jul 19, 2022
@justusschock
Copy link
Member Author

@akihironitta wouldnt we just squash merge it? That should be fine, no?

Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @akihironitta !

we should do rebase and merge with 2 commits to preserve the git history. squash and merge will not keep it.

src/pytorch_lightning/accelerators/gpu.py Outdated Show resolved Hide resolved
tests/tests_pytorch/deprecated_api/test_remove_1-9.py Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 force-pushed the reroute_gpu_accelerator branch from 8124087 to 9f19717 Compare July 19, 2022 10:20
@justusschock justusschock force-pushed the reroute_gpu_accelerator branch from 9f19717 to d630a2c Compare July 19, 2022 11:34
@rohitgr7 rohitgr7 force-pushed the reroute_gpu_accelerator branch from d630a2c to 3247b1f Compare July 19, 2022 11:45
@lexierule lexierule merged commit abf82b3 into master Jul 19, 2022
@lexierule lexierule deleted the reroute_gpu_accelerator branch July 19, 2022 17:06
@rohitgr7 rohitgr7 mentioned this pull request Jul 21, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: cuda Compute Unified Device Architecture GPU deprecation Includes a deprecation ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants