Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed deprecated pytorch_lightning.overrides.distributed.IndexBatchSamplerWrapper.batch_indices #13565

Merged
merged 11 commits into from
Jul 13, 2022
Merged

Removed deprecated pytorch_lightning.overrides.distributed.IndexBatchSamplerWrapper.batch_indices #13565

merged 11 commits into from
Jul 13, 2022

Conversation

samz5320
Copy link
Contributor

@samz5320 samz5320 commented Jul 7, 2022 •
edited by awaelchli
Loading

What does this PR do?

Part of #12521

Does your PR introduce any breaking changes? If yes, please list them.

Removes the deprecated pytorch_lightning.overrides.distributed.IndexBatchSamplerWrapper.batch_indices

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added refactor breaking change Includes a breaking change community This PR is from the community labels Jul 7, 2022
@awaelchli awaelchli added this to the pl:1.7 milestone Jul 7, 2022
akihironitta
akihironitta approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samz5320 Looks good to me! Thank you for your first contribution! 🚀

src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jul 7, 2022
@akihironitta akihironitta mentioned this pull request Jul 9, 2022
Closed
44 tasks
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 11, 2022
@akihironitta akihironitta enabled auto-merge (squash) July 12, 2022 03:42
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 12, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 12, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 12, 2022
@akihironitta akihironitta merged commit 5624674 into Lightning-AI:master Jul 13, 2022
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
@samz5320 @akihironitta
@carmocca @jerome-habana
Removed deprecated `pytorch_lightning.overrides.distributed.IndexBatc…
4239564 
…hSamplerWrapper.batch_indices` (Lightning-AI#13565)

* Removed the deprecated   method

* Removed deprecated  IndexBatchSamplerWrapper.batch_indices

* Update src/pytorch_lightning/CHANGELOG.md

* Missed code

Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
breaking change Includes a breaking change community This PR is from the community ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@samz5320 @awaelchli @Borda @carmocca @akihironitta