Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Strategy.post_dispatch #13461

Merged
merged 13 commits into from
Jul 15, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 29, 2022

What does this PR do?

Part of #12521

Does your PR introduce any breaking changes? If yes, please list them.

Yes

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @akihironitta @justusschock

@awaelchli awaelchli added breaking change Includes a breaking change strategy labels Jun 29, 2022
@awaelchli awaelchli added this to the pl:1.7 milestone Jun 29, 2022
@awaelchli awaelchli marked this pull request as ready for review June 29, 2022 22:34
@mergify mergify bot added the ready PRs ready to be merged label Jun 30, 2022
@akihironitta akihironitta enabled auto-merge (squash) July 4, 2022 22:32
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 5, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 9, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 11, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 12, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 13, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 14, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 14, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 14, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@akihironitta akihironitta merged commit d42711f into master Jul 15, 2022
@akihironitta akihironitta deleted the refactor/remove-deprecated-post-dispatch branch July 15, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged strategy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants