Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation when accelerator is a string #13417

Merged
merged 9 commits into from
Jun 29, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 27, 2022

What does this PR do?

Fixes #12698

Choosing accelerator="cocofruit" would silently convert it to "cpu".
Now, we will raise an error. See the added test.

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @kaushikb11 @awaelchli @ninginthecloud @akihironitta @rohitgr7

@awaelchli awaelchli added this to the pl:1.6.x milestone Jun 27, 2022
@mergify mergify bot removed the has conflicts label Jun 27, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !

@mergify mergify bot added the ready PRs ready to be merged label Jun 27, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 29, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 29, 2022
@awaelchli awaelchli enabled auto-merge (squash) June 29, 2022 18:55
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Jun 29, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 29, 2022
@awaelchli awaelchli merged commit 1f85b6d into master Jun 29, 2022
@awaelchli awaelchli deleted the bugfix/fix-accelerator-str-validation branch June 29, 2022 22:42
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
rohitgr7 added a commit that referenced this pull request Jul 1, 2022
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator bug Something isn't working ready PRs ready to be merged trainer: connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choosing an invalid accelerator does not raise an error
5 participants