-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validation when accelerator is a string #13417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…ation' into bugfix/fix-accelerator-str-validation
awaelchli
requested review from
tchaton,
SeanNaren,
carmocca,
Borda,
williamFalcon,
justusschock,
kaushikb11 and
rohitgr7
as code owners
June 27, 2022 15:32
tchaton
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch !
carmocca
approved these changes
Jun 27, 2022
otaj
approved these changes
Jun 28, 2022
rohitgr7
approved these changes
Jun 28, 2022
src/pytorch_lightning/trainer/connectors/accelerator_connector.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Rohit Gupta <[email protected]>
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Jun 29, 2022
mergify
bot
added
ready
PRs ready to be merged
has conflicts
and removed
ready
PRs ready to be merged
labels
Jun 29, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Jun 29, 2022
rohitgr7
added a commit
that referenced
this pull request
Jul 1, 2022
Co-authored-by: Rohit Gupta <[email protected]>
jerome-habana
pushed a commit
to jerome-habana/lightning
that referenced
this pull request
Jul 14, 2022
Co-authored-by: Rohit Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12698
Choosing
accelerator="cocofruit"
would silently convert it to"cpu"
.Now, we will raise an error. See the added test.
Does your PR introduce any breaking changes? If yes, please list them.
No.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @justusschock @kaushikb11 @awaelchli @ninginthecloud @akihironitta @rohitgr7