Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert validation loop config warnings to PossibleUserWarning #13377

Merged
merged 7 commits into from
Jun 29, 2022
Merged

Convert validation loop config warnings to PossibleUserWarning #13377

merged 7 commits into from
Jun 29, 2022

Conversation

CompRhys
Copy link
Contributor

@CompRhys CompRhys commented Jun 22, 2022

What does this PR do?

Extends #10644 by making more warnings PossibleUserWarning, related to #13358 for cleaning-up/reducing stdout verbosity.

Does your PR introduce any breaking changes? If yes, please list them.

If users are already filtering UserWarning code will no longer filter messages converted to PossibleUserWarning.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@CompRhys
Copy link
Contributor Author

Have updated CHANGELOG.md but feel this is minor

@mergify mergify bot added the ready PRs ready to be merged label Jun 23, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 27, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 27, 2022
@awaelchli awaelchli added the loops Related to the Loop API label Jun 28, 2022
@awaelchli awaelchli added this to the pl:1.7 milestone Jun 28, 2022
@awaelchli awaelchli enabled auto-merge (squash) June 29, 2022 20:25
@awaelchli awaelchli merged commit 8c4d640 into Lightning-AI:master Jun 29, 2022
@CompRhys CompRhys deleted the val-pos-user-warn branch June 29, 2022 22:35
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loops Related to the Loop API ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants