-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pytorch lightning.callbacks.lr monitor.learning rate monitor.lr_sch_names #13353
Merged
carmocca
merged 8 commits into
Lightning-AI:master
from
rschireman:remove-pytorch_lightning.callbacks.lr_monitor.LearningRateMonitor.lr_sch_names
Jun 22, 2022
Merged
Remove pytorch lightning.callbacks.lr monitor.learning rate monitor.lr_sch_names #13353
carmocca
merged 8 commits into
Lightning-AI:master
from
rschireman:remove-pytorch_lightning.callbacks.lr_monitor.LearningRateMonitor.lr_sch_names
Jun 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihironitta
added
breaking change
Includes a breaking change
callback: lr monitor
labels
Jun 21, 2022
Hi @rschireman, thanks for working on this! Could you add a changelog entry for Once it's added, let's mark this PR as ready for review and see all the existing tests pass in our CI :] |
for more information, see https://pre-commit.ci
rschireman
requested review from
williamFalcon,
tchaton,
carmocca,
Borda,
kaushikb11,
SeanNaren,
awaelchli,
justusschock and
rohitgr7
as code owners
June 21, 2022 16:52
awaelchli
approved these changes
Jun 21, 2022
akihironitta
approved these changes
Jun 21, 2022
Borda
approved these changes
Jun 21, 2022
carmocca
approved these changes
Jun 22, 2022
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #12521 by removing the deprecated
pytorch lightning.callbacks.lr monitor.learning rate monitor.lr_sch_names
resolves #10066
Does your PR introduce any breaking changes? If yes, please list them.
Yes, removes pytorch lightning.callbacks.lr monitor.learning rate monitor.lr_sch_names`
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃