Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytorch lightning.callbacks.lr monitor.learning rate monitor.lr_sch_names #13353

Merged
merged 8 commits into from
Jun 22, 2022
Merged

Remove pytorch lightning.callbacks.lr monitor.learning rate monitor.lr_sch_names #13353

merged 8 commits into from
Jun 22, 2022

Conversation

rschireman
Copy link
Contributor

@rschireman rschireman commented Jun 21, 2022

What does this PR do?

Fixes part of #12521 by removing the deprecated pytorch lightning.callbacks.lr monitor.learning rate monitor.lr_sch_names

resolves #10066

Does your PR introduce any breaking changes? If yes, please list them.

Yes, removes pytorch lightning.callbacks.lr monitor.learning rate monitor.lr_sch_names`

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rschireman
Copy link
Contributor Author

@akihironitta

@akihironitta akihironitta added this to the pl:1.7 milestone Jun 21, 2022
@akihironitta akihironitta self-assigned this Jun 21, 2022
@akihironitta
Copy link
Contributor

akihironitta commented Jun 21, 2022

Hi @rschireman, thanks for working on this!

Could you add a changelog entry for both add_lr_sch_names and lr_sch_names?
(UPDATE: an entry for add_lr_sch_names is actually unnecessary as it's not part of the public API. Sorry for the confusion.)

Once it's added, let's mark this PR as ready for review and see all the existing tests pass in our CI :]

@mergify mergify bot added the ready PRs ready to be merged label Jun 21, 2022
@carmocca carmocca merged commit 8266300 into Lightning-AI:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change callback: lr monitor ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants