-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable timeout for DDPStrategy #13244
Conversation
enable timeout for DDPStrategy
for more information, see https://pre-commit.ci
remove empty line
@carmocca should we also set the env variables for the non-gloo backends? Or at least check them and error out early? |
Add a timeout unit test
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as it is!
Let's continue the discussion about the env vars in the issue and if necessary, open a separate PR for checking them.
for more information, see https://pre-commit.ci
Head branch was pushed to by a user without write access
How is one supposed to use this in a yaml config? the timeout arg is class with a named arg. |
What does this PR do?
Enable timeout for DDPStrategy
Fixes #13211
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃