Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register torch's unresolvable import paths in cli module #13153

Merged
merged 6 commits into from
Jun 1, 2022
Merged

Register torch's unresolvable import paths in cli module #13153

merged 6 commits into from
Jun 1, 2022

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented May 25, 2022

What does this PR do?

Fixes #13092

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added bug Something isn't working lightningcli pl.cli.LightningCLI labels May 25, 2022
@mauvilsa mauvilsa marked this pull request as ready for review May 25, 2022 16:19
tests/utilities/test_cli.py Outdated Show resolved Hide resolved
@carmocca carmocca added this to the 1.6.x milestone May 25, 2022
@mergify mergify bot removed the has conflicts label Jun 1, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jun 1, 2022
@carmocca carmocca merged commit 18cdfab into Lightning-AI:master Jun 1, 2022
@carmocca carmocca modified the milestones: 1.6.x, 1.7 Jun 1, 2022
@carmocca
Copy link
Contributor

carmocca commented Jun 1, 2022

Not including this in 1.6.x because increasing the required dependency would be a breaking chage.

@mauvilsa mauvilsa deleted the cli-torch-softmax-issue-13092 branch June 1, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lightningcli pl.cli.LightningCLI ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use torch.softmax as a Callable parameter in CLI
4 participants