Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed process_position argument from Trainer Class #13071

Merged
merged 3 commits into from
May 16, 2022
Merged

Removed process_position argument from Trainer Class #13071

merged 3 commits into from
May 16, 2022

Conversation

shenoynikhil
Copy link
Contributor

@shenoynikhil shenoynikhil commented May 14, 2022

What does this PR do?

Part of #12521

resolves #9222

This PR removes the process_position argument in the Trainer Class and the corresponding changes. Made the following edits,

  • Removed process_position from Trainer and Callback Connector Class
  • Removed the test in the deprecation tests file
  • Removed the documentation in trainer.rst

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@shenoynikhil shenoynikhil changed the title [WIP] Removed process_position argument from Trainer Class Removed process_position argument from Trainer Class May 14, 2022
@shenoynikhil shenoynikhil marked this pull request as ready for review May 14, 2022 09:10
@shenoynikhil shenoynikhil changed the title Removed process_position argument from Trainer Class Removed process_position argument from Trainer Class May 15, 2022
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@mergify mergify bot added the ready PRs ready to be merged label May 15, 2022
@rohitgr7 rohitgr7 added breaking change Includes a breaking change trainer: argument labels May 15, 2022
@rohitgr7 rohitgr7 added this to the 1.7 milestone May 15, 2022
@carmocca carmocca merged commit 830da2c into Lightning-AI:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged trainer: argument
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants