Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename callbacks/base.py to callbacks/callback.py #13031

Merged
merged 2 commits into from
May 19, 2022
Merged

Rename callbacks/base.py to callbacks/callback.py #13031

merged 2 commits into from
May 19, 2022

Conversation

shantam-8
Copy link
Contributor

@shantam-8 shantam-8 commented May 10, 2022

What does this PR do?

Renames callbacks/base.py to callbacks/callback.py and changes other instances in different parts of the repository. Also changes callbacks/base.py to provide a deprecation warning.

Fixes #11973

IMPORTANT: This PR needs to be "Rebase and Merge"d. Do not add merge commits!

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

pytorch_lightning/callbacks/base.py Outdated Show resolved Hide resolved
@akihironitta akihironitta added refactor callback community This PR is from the community labels May 11, 2022
@akihironitta akihironitta added this to the 1.7 milestone May 11, 2022
@mergify mergify bot added the ready PRs ready to be merged label May 11, 2022
@rohitgr7 rohitgr7 requested a review from carmocca May 11, 2022 17:57
@carmocca carmocca enabled auto-merge (rebase) May 11, 2022 18:17
@carmocca carmocca added deprecation Includes a deprecation and removed refactor labels May 11, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels May 18, 2022
@awaelchli
Copy link
Contributor

@rohitgr7 could you rebase once more? Thx

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 18, 2022
@carmocca carmocca merged commit eb21135 into Lightning-AI:master May 19, 2022
ashleve pushed a commit to ashleve/pytorch-lightning that referenced this pull request May 19, 2022
ashleve pushed a commit to ashleve/pytorch-lightning that referenced this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback community This PR is from the community deprecation Includes a deprecation ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename callbacks/base.py to callbacks/callback.py
7 participants