-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename callbacks/base.py to callbacks/callback.py #13031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantam-8
requested review from
williamFalcon,
tchaton,
awaelchli,
ananthsub,
carmocca,
Borda,
kaushikb11,
edenlightning,
SeanNaren,
justusschock and
rohitgr7
as code owners
May 10, 2022 22:04
ananthsub
suggested changes
May 11, 2022
rohitgr7
approved these changes
May 11, 2022
ananthsub
approved these changes
May 11, 2022
carmocca
reviewed
May 11, 2022
12 tasks
carmocca
approved these changes
May 11, 2022
akihironitta
approved these changes
May 12, 2022
11 tasks
Borda
approved these changes
May 12, 2022
awaelchli
approved these changes
May 18, 2022
@rohitgr7 could you rebase once more? Thx |
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
May 18, 2022
carmocca
approved these changes
May 19, 2022
carmocca
pushed a commit
that referenced
this pull request
May 19, 2022
ashleve
pushed a commit
to ashleve/pytorch-lightning
that referenced
this pull request
May 19, 2022
ashleve
pushed a commit
to ashleve/pytorch-lightning
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
callback
community
This PR is from the community
deprecation
Includes a deprecation
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Renames callbacks/base.py to callbacks/callback.py and changes other instances in different parts of the repository. Also changes callbacks/base.py to provide a deprecation warning.
Fixes #11973
IMPORTANT: This PR needs to be "Rebase and Merge"d. Do not add merge commits!
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃