Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile LightningDataModule hooks #12971

Merged
merged 5 commits into from
May 6, 2022
Merged

Profile LightningDataModule hooks #12971

merged 5 commits into from
May 6, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented May 4, 2022

What does this PR do?

Fixes #12967

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @kaushikb11 @ninginthecloud @rohitgr7 @awaelchli @ananthsub @jjenniferdai

@rohitgr7 rohitgr7 added feature Is an improvement or enhancement profiler lightningdatamodule pl.LightningDataModule labels May 4, 2022
@rohitgr7
Copy link
Contributor Author

rohitgr7 commented May 4, 2022

not sure what should the best minimal test to validate the change. Any recommendations?

Thank you :)

@rohitgr7 rohitgr7 added this to the 1.7 milestone May 4, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review May 4, 2022 11:52
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
@carmocca
Copy link
Contributor

carmocca commented May 4, 2022

not sure what should the best minimal test to validate the change. Any recommendations?

I added a test like that in #12124 if you want to copy the pattern

@mergify mergify bot added the has conflicts label May 4, 2022
@mergify mergify bot removed the has conflicts label May 4, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels May 5, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 6, 2022
@mergify mergify bot added the ready PRs ready to be merged label May 6, 2022
@carmocca carmocca enabled auto-merge (squash) May 6, 2022 10:10
tests/core/test_datamodules.py Show resolved Hide resolved
@carmocca carmocca merged commit c02dc85 into master May 6, 2022
@carmocca carmocca deleted the feat/profile_dm_hooks branch May 6, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement lightningdatamodule pl.LightningDataModule profiler ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile LightningDataModule hooks
5 participants