-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Sampler Wrappers for custom samplers in distributed environment #12959
Conversation
@Borda Where would you like us to clarify more? In documentation, in docstrings, in changelog? |
probably in the same comment, you mention that it was inspired from... |
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Carlos Mocholí <[email protected]>
At this moment, I believe the PR is ready to go. We decided to move from Catalyst's implementation. Currently, there is @carmocca , can you merge please if the final pass of review still looks good to you? Thanks! |
What does this PR do?
Fixes #9883
Closes #12866, #12413
Adds a
DistributedSamplerWrapper
andUnrepeatedDistributedSamplerWrapper
in order to wrap custom samplers in distributed environment.Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @awaelchli @rohitgr7 @akihironitta @justusschock @ninginthecloud @otaj