Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support predict_dataset in LightningDataModule.from_datasets #12942

Merged

Conversation

digital-idiot
Copy link
Contributor

Added argument to pass predict_dataset and implemented associated method predict_dataloader

What does this PR do?

Added argument to pass predict_dataset and implemented associated method predict_dataloader when creating LightningDataModule instance using from_datasets class metod.

Does your PR introduce any breaking changes?

  • N/A

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

…ating LightningDataModule instance using from_datasets class method
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind add a chlog entry?

@mergify mergify bot added the ready PRs ready to be merged label May 2, 2022
@carmocca carmocca added community This PR is from the community lightningdatamodule pl.LightningDataModule labels May 2, 2022
@carmocca carmocca added this to the 1.7 milestone May 2, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels May 3, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pytorch_lightning/core/datamodule.py Show resolved Hide resolved
@akihironitta akihironitta changed the title Added argument to pass predict_dataset and associated method when cre… Support predict_dataset in LightningDataModule.from_datasets May 4, 2022
@rohitgr7 rohitgr7 requested a review from akihironitta May 4, 2022 11:43
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 4, 2022
@mergify mergify bot added the ready PRs ready to be merged label May 4, 2022
@carmocca carmocca enabled auto-merge (squash) May 4, 2022 11:50
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @digital-idiot @rohitgr7!

@carmocca carmocca merged commit 2ffc0de into Lightning-AI:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community lightningdatamodule pl.LightningDataModule ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

predict_dataloader is missing in LightningDataModule
5 participants