-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support predict_dataset
in LightningDataModule.from_datasets
#12942
Support predict_dataset
in LightningDataModule.from_datasets
#12942
Conversation
…ating LightningDataModule instance using from_datasets class method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mind add a chlog entry?
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
predict_dataset
in LightningDataModule.from_datasets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @digital-idiot @rohitgr7!
Added argument to pass
predict_dataset
and implemented associated methodpredict_dataloader
What does this PR do?
Added argument to pass
predict_dataset
and implemented associated methodpredict_dataloader
when creatingLightningDataModule
instance usingfrom_datasets
class metod.Does your PR introduce any breaking changes?
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list: