-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break lazy accumulation of graphs #12938
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Habana bridge lazily accumulates ops. This change ensures we break graph exectuion across different stages to get better performance and optimal resource usage. Signed-off-by: Jerome <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Jerome <[email protected]>
Signed-off-by: Jerome <[email protected]>
@jerome-habana Are there any benchmarks with and without this PR changes? |
For simple models, the change will not have any visible impact. However, for larger models, we can see considerable gain in performance. The results are presented in PyTorch model repository of habana. |
jerome-habana
requested review from
tchaton,
SeanNaren,
awaelchli,
justusschock,
kaushikb11,
williamFalcon,
Borda,
carmocca and
rohitgr7
as code owners
May 5, 2022 13:15
kaushikb11
reviewed
May 5, 2022
kaushikb11
approved these changes
May 5, 2022
carmocca
approved these changes
May 5, 2022
Borda
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Is an improvement or enhancement
performance
ready
PRs ready to be merged
strategy: hpu (external)
HPUParallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Habana bridge lazily accumulates ops. This change
ensures we break graph exectuion across different stages to
get better performance and optimal resource usage.
Signed-off-by: Jerome [email protected]
What does this PR do?
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃