Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break lazy accumulation of graphs #12938

Merged
merged 8 commits into from
May 5, 2022

Conversation

jerome-habana
Copy link
Contributor

@jerome-habana jerome-habana commented Apr 30, 2022

Habana bridge lazily accumulates ops. This change
ensures we break graph exectuion across different stages to
get better performance and optimal resource usage.

Signed-off-by: Jerome [email protected]

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

jerome-habana and others added 4 commits April 30, 2022 06:59
Habana bridge lazily accumulates ops. This change
ensures we break graph exectuion across different stages to
get better performance and optimal resource usage.

Signed-off-by: Jerome <[email protected]>
Signed-off-by: Jerome <[email protected]>
@kaushikb11
Copy link
Contributor

@jerome-habana Are there any benchmarks with and without this PR changes?

@jerome-habana
Copy link
Contributor Author

@jerome-habana Are there any benchmarks with and without this PR changes?

For simple models, the change will not have any visible impact. However, for larger models, we can see considerable gain in performance. The results are presented in PyTorch model repository of habana.

@kaushikb11 kaushikb11 added this to the 1.7 milestone May 5, 2022
@carmocca carmocca added feature Is an improvement or enhancement performance labels May 5, 2022
@mergify mergify bot added the ready PRs ready to be merged label May 5, 2022
@carmocca carmocca merged commit 4818229 into Lightning-AI:master May 5, 2022
@jerome-habana jerome-habana deleted the hpu_mark_step branch May 6, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement performance ready PRs ready to be merged strategy: hpu (external) HPUParallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants