-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated TestTubeLogger
#12859
Remove deprecated TestTubeLogger
#12859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @stanbiryukov Thank you for your work! The CI jobs are failing due to the import statement here. Would you mind removing this import statement, too?
File "/home/runner/work/pytorch-lightning/pytorch-lightning/pytorch_lightning/loggers/__init__.py", line 28, in <module>
from pytorch_lightning.loggers.test_tube import _TESTTUBE_AVAILABLE, TestTubeLogger # noqa: F401
ModuleNotFoundError: No module named 'pytorch_lightning.loggers.test_tube'
Thanks, @akihironitta. Good point on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once an entry is added to the changelog, LGTM!
Thanks @akihironitta - added the removal entry to CHANGELOG.md |
TestTubeLogger
What does this PR do?
Fixes #12858, which is subset of #12521
Does your PR introduce any breaking changes? If yes, please list them.
Removes
from pytorch_lightning.loggers import TestTubeLogger
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Yes!
Make sure you had fun coding 🙃