Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reloading the last checkpoint saved by passing ckpt_path="last" #12816

Merged
merged 28 commits into from
May 5, 2022

Conversation

otaj
Copy link
Contributor

@otaj otaj commented Apr 20, 2022

What does this PR do?

Implements #11912

Allows you to pass keyword "last" to ckpt_path argument. "best" still remains the default value if None is passed, except one particular case - in method fit when fault tolerant training is enabled.

Value last selects the checkpoint with the latest modified timestamp from set of all last checkpoints (currently only one, because they overwrite each other, but once #5030 is solved, it could be a different one) and all fault tolerant checkpoints. If no checkpoint in these two sets is found (due to fault tolerant training not being enabled and passing save_last=False to ModelCheckpoint), warning is issued and no checkpoint is loaded.

What needs to be done before making it non-draft

  • Write tests
  • Add changelog entry
  • Update documentation
    • is the change of docs big enough?
  • Discuss whether this design makes sense

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @awaelchli @ananthsub @ninginthecloud @rohitgr7 @carmocca @justusschock @jjenniferdai

@otaj otaj added feature Is an improvement or enhancement checkpointing Related to checkpointing fault tolerance callback: model checkpoint labels Apr 20, 2022
@otaj otaj added this to the 1.7 milestone Apr 20, 2022
@otaj otaj self-assigned this Apr 20, 2022
@otaj otaj requested a review from carmocca April 20, 2022 09:23
@otaj otaj marked this pull request as ready for review April 22, 2022 07:55
@otaj otaj requested a review from awaelchli April 25, 2022 08:00
@otaj otaj linked an issue Apr 26, 2022 that may be closed by this pull request
@mergify mergify bot removed the has conflicts label Apr 27, 2022
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've pushed some minor simplification to the code and greater simplifications to the test to narrow their scope to just these warnings.

CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/trainer/trainer.py Show resolved Hide resolved
@carmocca carmocca changed the title Feature/last checkpoint Add support for reloading the last checkpoint saved by passing ckpt_path="last" Apr 28, 2022
tests/trainer/test_trainer.py Outdated Show resolved Hide resolved
@mergify mergify bot added the has conflicts label May 3, 2022
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@carmocca carmocca enabled auto-merge (squash) May 4, 2022 13:33
@mergify mergify bot removed the has conflicts label May 4, 2022
@mergify mergify bot added the ready PRs ready to be merged label May 4, 2022
@carmocca carmocca merged commit e2ea9f0 into master May 5, 2022
@carmocca carmocca deleted the feature/last_checkpoint branch May 5, 2022 08:33
@otaj otaj mentioned this pull request Sep 27, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback: model checkpoint checkpointing Related to checkpointing fault tolerance feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Introduce .fit(ckpt_path="last")
5 participants