-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated LightningDataModule.test_transforms
#12773
Merged
rohitgr7
merged 8 commits into
Lightning-AI:master
from
rschireman:remove-LightningDataModule.test_transforms
Apr 21, 2022
Merged
Remove the deprecated LightningDataModule.test_transforms
#12773
rohitgr7
merged 8 commits into
Lightning-AI:master
from
rschireman:remove-LightningDataModule.test_transforms
Apr 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschireman
requested review from
williamFalcon,
awaelchli,
ananthsub,
carmocca,
edenlightning,
tchaton,
Borda,
SeanNaren,
justusschock,
kaushikb11 and
rohitgr7
as code owners
April 15, 2022 14:45
awaelchli
approved these changes
Apr 15, 2022
44 tasks
carmocca
approved these changes
Apr 18, 2022
kaushikb11
approved these changes
Apr 18, 2022
Borda
approved these changes
Apr 18, 2022
rohitgr7
reviewed
Apr 18, 2022
Co-authored-by: Akihiro Nitta <[email protected]>
akihironitta
approved these changes
Apr 18, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Apr 21, 2022
carmocca
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #12521 by removing the deprecated LightningDataModule.test_transforms
Does your PR introduce any breaking changes? If yes, please list them.
Removes deprecated
LightningDataModule.test_transforms
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃