-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated LightningDataModule.val_transforms
#12763
Remove the deprecated LightningDataModule.val_transforms
#12763
Conversation
for more information, see https://pre-commit.ci
…m:rschireman/pytorch-lightning into remove-LightningDataModule.val_transforms
Hi @rschireman! Thank you for working on this! One of the CI jobs seems to have failed as seen in https://results.pre-commit.ci/run/github/178626720/1650559831.ycbj-8PdT7WOECLh8cRgcQ. Could you remove unused import statements to fix the CI failure? |
Head branch was pushed to by a user without write access
@akihironitta no problem, PyTorch Lightning is awesome so it's my pleasure! I just removed the unused imports and pushed changes! |
@rschireman It seems it has passed now :) Thanks again for your action! ❤️ |
What does this PR do?
Fixes part of #12521 by removing the deprecated
LightningDataModule.val_transforms
Does your PR introduce any breaking changes? If yes, please list them.
Removes deprecated
LightningDataModule.val_transforms
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃