Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated LightningDataModule.val_transforms #12763

Merged
merged 8 commits into from
Apr 22, 2022
Merged

Remove the deprecated LightningDataModule.val_transforms #12763

merged 8 commits into from
Apr 22, 2022

Conversation

rschireman
Copy link
Contributor

@rschireman rschireman commented Apr 14, 2022

What does this PR do?

Fixes part of #12521 by removing the deprecated LightningDataModule.val_transforms

Does your PR introduce any breaking changes? If yes, please list them.

Removes deprecated LightningDataModule.val_transforms

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added breaking change Includes a breaking change refactor labels Apr 15, 2022
@awaelchli awaelchli added this to the 1.7 milestone Apr 15, 2022
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Apr 15, 2022
@carmocca carmocca enabled auto-merge (squash) April 21, 2022 16:50
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Apr 21, 2022
@akihironitta
Copy link
Contributor

Hi @rschireman! Thank you for working on this! One of the CI jobs seems to have failed as seen in https://results.pre-commit.ci/run/github/178626720/1650559831.ycbj-8PdT7WOECLh8cRgcQ. Could you remove unused import statements to fix the CI failure?

auto-merge was automatically disabled April 22, 2022 00:33

Head branch was pushed to by a user without write access

@rschireman
Copy link
Contributor Author

@akihironitta no problem, PyTorch Lightning is awesome so it's my pleasure! I just removed the unused imports and pushed changes!

@akihironitta
Copy link
Contributor

@rschireman It seems it has passed now :) Thanks again for your action! ❤️

@akihironitta akihironitta enabled auto-merge (squash) April 22, 2022 00:38
@akihironitta akihironitta self-requested a review April 22, 2022 01:24
@akihironitta akihironitta merged commit 9b2b1bb into Lightning-AI:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants