Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback collection through entry points #12739

Merged
merged 46 commits into from
May 3, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Apr 12, 2022

What does this PR do?

Fixes #9741

Adds support for Callback collection through Entry Points. See the added docs for a summary of what this feature does.

TODO:

  • tests
  • discuss api, verify terminology

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @awaelchli @ananthsub @daniellepintz @rohitgr7 @justusschock @kaushikb11 @ninginthecloud

@awaelchli awaelchli changed the title Feature/callback entry points Callback collection through entry points Apr 12, 2022
@awaelchli awaelchli added feature Is an improvement or enhancement callback trainer: connector labels Apr 12, 2022
@awaelchli awaelchli added this to the 1.7 milestone Apr 12, 2022
@awaelchli awaelchli force-pushed the feature/callback-entry-points branch from f3843a0 to 785da7d Compare April 14, 2022 10:04
@awaelchli awaelchli changed the base branch from master to bugfix/fix-python-version-check April 14, 2022 10:05
Base automatically changed from bugfix/fix-python-version-check to master April 14, 2022 22:33
@awaelchli awaelchli marked this pull request as ready for review April 14, 2022 22:53
@mergify mergify bot added the ready PRs ready to be merged label Apr 22, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Apr 27, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 3, 2022
@carmocca carmocca enabled auto-merge (squash) May 3, 2022 15:32
docs/source/extensions/entry_points.rst Show resolved Hide resolved
docs/source/extensions/entry_points.rst Outdated Show resolved Hide resolved
@carmocca carmocca merged commit 5641836 into master May 3, 2022
@carmocca carmocca deleted the feature/callback-entry-points branch May 3, 2022 16:54
akihironitta added a commit that referenced this pull request May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback feature Is an improvement or enhancement ready PRs ready to be merged trainer: connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a mechanism to allow for production environment specific default plugins
6 participants