-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callback collection through entry points #12739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
changed the title
Feature/callback entry points
Callback collection through entry points
Apr 12, 2022
awaelchli
added
feature
Is an improvement or enhancement
callback
trainer: connector
labels
Apr 12, 2022
awaelchli
commented
Apr 12, 2022
for more information, see https://pre-commit.ci
awaelchli
force-pushed
the
feature/callback-entry-points
branch
from
April 14, 2022 10:04
f3843a0
to
785da7d
Compare
for more information, see https://pre-commit.ci
awaelchli
changed the base branch from
master
to
bugfix/fix-python-version-check
April 14, 2022 10:05
awaelchli
commented
Apr 14, 2022
kaushikb11
reviewed
Apr 21, 2022
kaushikb11
approved these changes
Apr 22, 2022
ananthsub
reviewed
Apr 22, 2022
ananthsub
reviewed
Apr 22, 2022
carmocca
reviewed
Apr 22, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
May 3, 2022
Borda
approved these changes
May 3, 2022
Co-authored-by: Jirka Borovec <[email protected]>
carmocca
approved these changes
May 3, 2022
akihironitta
added a commit
that referenced
this pull request
May 28, 2022
This reverts commit 5641836.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9741
Adds support for Callback collection through Entry Points. See the added docs for a summary of what this feature does.
TODO:
Does your PR introduce any breaking changes? If yes, please list them.
No.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @awaelchli @ananthsub @daniellepintz @rohitgr7 @justusschock @kaushikb11 @ninginthecloud