Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for DDP2 strategy #12705

Merged
merged 27 commits into from
Jun 29, 2022
Merged

Remove support for DDP2 strategy #12705

merged 27 commits into from
Jun 29, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Apr 11, 2022

What does this PR do?

Fixes #12584

Raises an error for users who subclass or use the DDP2Strategy/DDP2Plugin. Raises an error for everyone trying to use it with strategy="ddp2".

Does your PR introduce any breaking changes? If yes, please list them.

Yes. If you try this, you get an error:

trainer = Trainer(strategy="ddp2")

Since DDP2 is broken and unsupported on torch >= 1.9, you will need to downgrade Lightning to < 1.5 with torch < 1.9.
It is possible to instantiate the DDP2Strategy and pass it into the strategy argument, but it will still print a deprecation warning.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @tchaton @rohitgr7 @Borda @justusschock @awaelchli

@awaelchli awaelchli added strategy: ddp2 deprecation Includes a deprecation breaking change Includes a breaking change labels Apr 11, 2022
@awaelchli awaelchli added this to the 1.7 milestone Apr 11, 2022
pytorch_lightning/strategies/ddp2.py Outdated Show resolved Hide resolved
pytorch_lightning/strategies/ddp2.py Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 21, 2022
@Borda Borda requested review from rohitgr7 and justusschock June 21, 2022 21:59
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 22, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 27, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat !

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 27, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 27, 2022
@awaelchli awaelchli enabled auto-merge (squash) June 29, 2022 13:54
@awaelchli awaelchli merged commit ddbf955 into master Jun 29, 2022
@awaelchli awaelchli deleted the feature/deprecate-ddp2 branch June 29, 2022 15:06
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change deprecation Includes a deprecation ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Deprecate DataParallel2 Strategy (DDP2)
9 participants