Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated XLAStatsMonitor #12688

Merged
merged 13 commits into from
Apr 12, 2022

Conversation

ankitaS11
Copy link
Contributor

@ankitaS11 ankitaS11 commented Apr 10, 2022

What does this PR do?

Part of #12521.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Apr 10, 2022
@akihironitta akihironitta added callback breaking change Includes a breaking change labels Apr 10, 2022
@akihironitta akihironitta added this to the 1.7 milestone Apr 10, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitaS11 Thank you for working on this! Could you remove the following occurrences in the documentation?

./docs/source/extensions/callbacks.rst:109:    XLAStatsMonitor
./docs/source/api_references.rst:102:    XLAStatsMonitor

@awaelchli
Copy link
Contributor

@ankitaS11 ping us if you need help resolving conflicts or addressing #12688 (review) :) Happy to help!

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Apr 12, 2022
@ankitaS11
Copy link
Contributor Author

@ankitaS11 Thank you for working on this! Could you remove the following occurrences in the documentation?

./docs/source/extensions/callbacks.rst:109:    XLAStatsMonitor
./docs/source/api_references.rst:102:    XLAStatsMonitor

Thanks @akihironitta, I have made the changes in the recent commit.

Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@rohitgr7 rohitgr7 enabled auto-merge (squash) April 12, 2022 12:18
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitaS11 Thank you :) LGTM!

@rohitgr7 rohitgr7 merged commit 313eee0 into Lightning-AI:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change callback ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants