-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated XLAStatsMonitor
#12688
Remove deprecated XLAStatsMonitor
#12688
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankitaS11 Thank you for working on this! Could you remove the following occurrences in the documentation?
./docs/source/extensions/callbacks.rst:109: XLAStatsMonitor
./docs/source/api_references.rst:102: XLAStatsMonitor
@ankitaS11 ping us if you need help resolving conflicts or addressing #12688 (review) :) Happy to help! |
…-lightning into remove_XLAStatsMonitor
…-lightning into remove_XLAStatsMonitor
Thanks @akihironitta, I have made the changes in the recent commit. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankitaS11 Thank you :) LGTM!
What does this PR do?
Part of #12521.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃