Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gather_all_tensors to handle tensors of different sizes #12630

Merged
merged 10 commits into from
Jun 29, 2022
Merged

Update gather_all_tensors to handle tensors of different sizes #12630

merged 10 commits into from
Jun 29, 2022

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Apr 6, 2022 •
edited by github-actions bot
Loading

What does this PR do?

This was fixed in torchmetrics but not in Lightning
Reference Lightning-AI/torchmetrics#220

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @awaelchli @rohitgr7 @akihironitta

@ananthsub ananthsub added the distributed Generic distributed-related topic label Apr 6, 2022
@ananthsub ananthsub added this to the 1.6.x milestone Apr 6, 2022
carmocca
carmocca reviewed Apr 6, 2022
View reviewed changes
pytorch_lightning/utilities/distributed.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/distributed.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/distributed.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/distributed.py Outdated Show resolved Hide resolved
@ananthsub ananthsub marked this pull request as draft April 6, 2022 04:33
@ananthsub ananthsub marked this pull request as ready for review April 6, 2022 06:46
@mergify mergify bot added the has conflicts label Apr 6, 2022
@mergify mergify bot removed the has conflicts label Apr 6, 2022
awaelchli
awaelchli approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

pytorch_lightning/utilities/distributed.py Outdated Show resolved Hide resolved
tests/utilities/test_distributed.py Outdated Show resolved Hide resolved
tests/utilities/test_distributed.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Apr 7, 2022
four4fish
four4fish approved these changes Apr 7, 2022
View reviewed changes
pytorch_lightning/utilities/distributed.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/distributed.py Outdated Show resolved Hide resolved
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Apr 19, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 21, 2022
Borda
Borda approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@awaelchli awaelchli requested review from carmocca and rohitgr7 June 23, 2022 01:54
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 27, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 27, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 29, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 29, 2022
@awaelchli awaelchli enabled auto-merge (squash) June 29, 2022 15:46
@awaelchli awaelchli merged commit 7fca126 into master Jun 29, 2022
@awaelchli awaelchli deleted the gather-all-tensors-fix branch June 29, 2022 17:03
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
@ananthsub @pre-commit-ci
@Borda @awaelchli @jerome-habana
Update gather_all_tensors to handle tensors of different sizes (Light…
6338ad5 
…ning-AI#12630)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <[email protected]>
Co-authored-by: awaelchli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@four4fish four4fish four4fish approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@DuYicong515 DuYicong515 DuYicong515 approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
distributed Generic distributed-related topic ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6.x
Development

Successfully merging this pull request may close these issues.
7 participants
@ananthsub @awaelchli @Borda @carmocca @DuYicong515 @rohitgr7 @four4fish