-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide access to unwrapped model in Lite #12597
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
feature
Is an improvement or enhancement
fabric
lightning.fabric.Fabric
labels
Apr 3, 2022
justusschock
reviewed
Apr 4, 2022
for more information, see https://pre-commit.ci
awaelchli
requested review from
tchaton,
carmocca,
williamFalcon,
Borda,
SeanNaren,
kaushikb11 and
rohitgr7
as code owners
April 6, 2022 03:31
Borda
approved these changes
Apr 6, 2022
4 tasks
carmocca
approved these changes
Apr 12, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Apr 25, 2022
akihironitta
reviewed
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀
otaj
approved these changes
May 9, 2022
justusschock
approved these changes
May 9, 2022
rohitgr7
approved these changes
May 9, 2022
mergify
bot
added
ready
PRs ready to be merged
has conflicts
and removed
has conflicts
ready
PRs ready to be merged
labels
May 10, 2022
Gatekeeper merge |
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
May 11, 2022
carmocca
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fabric
lightning.fabric.Fabric
feature
Is an improvement or enhancement
priority: 0
High priority task
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12596
This PR enables attribute pass-through on the _LiteModule wrapper. When an attribute is not found on the wrapper, it tries to look it up on the original model that was passed into the setup method.
The _LiteModule wrapper now takes an optional argument
original_module
, which is the one passed in to theLite.setup
method. If we didn't do this, we wouldn't be able to access it, because theforward_module
is potentially already wrapped by something likeDistributedDataParallel
.Breaking change
This is a breaking change if you previously relied on
LiteModule.state_dict()
to save or load checkpoints. The old checkpoint won't load after this PR because of missing keys (_original_module, _forward_module).Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @tchaton @rohitgr7 @carmocca @justusschock @awaelchli