Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataclass support to _extract_batch_size #12573

Merged
merged 6 commits into from
Apr 15, 2022
Merged

Add dataclass support to _extract_batch_size #12573

merged 6 commits into from
Apr 15, 2022

Conversation

twsl
Copy link
Contributor

@twsl twsl commented Apr 1, 2022

What does this PR do?

Fixes #12572

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added feature Is an improvement or enhancement data handling Generic data-related topic labels Apr 2, 2022
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind add a changelog?

pytorch_lightning/utilities/data.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/data.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/data.py Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 added this to the 1.7 milestone Apr 4, 2022
@mergify mergify bot added the has conflicts label Apr 6, 2022
@mergify mergify bot removed the has conflicts label Apr 9, 2022
@twsl twsl requested a review from rohitgr7 April 9, 2022 15:41
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Apr 11, 2022
Co-authored-by: Akihiro Nitta <[email protected]>
@awaelchli awaelchli merged commit ae3226c into Lightning-AI:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data handling Generic data-related topic feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dataclasses in _extract_batch_size
5 participants