-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove LightningModule.summarize #12559
Merged
carmocca
merged 5 commits into
Lightning-AI:master
from
aniketmaurya:remove-lm_-summarize
Apr 2, 2022
Merged
remove LightningModule.summarize #12559
carmocca
merged 5 commits into
Lightning-AI:master
from
aniketmaurya:remove-lm_-summarize
Apr 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 tasks
akihironitta
added
breaking change
Includes a breaking change
lightningmodule
pl.LightningModule
labels
Apr 1, 2022
aniketmaurya
requested review from
williamFalcon,
tchaton,
awaelchli,
Borda,
SeanNaren,
carmocca,
justusschock,
kaushikb11 and
rohitgr7
as code owners
April 1, 2022 08:03
Borda
approved these changes
Apr 1, 2022
Borda
reviewed
Apr 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add chlog entry
auto-merge was automatically disabled
April 1, 2022 08:52
Head branch was pushed to by a user without write access
carmocca
approved these changes
Apr 1, 2022
kaushikb11
approved these changes
Apr 1, 2022
akihironitta
approved these changes
Apr 1, 2022
ananthsub
approved these changes
Apr 1, 2022
awaelchli
approved these changes
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
lightningmodule
pl.LightningModule
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #12521
resolves #8513
Does your PR introduce any breaking changes? If yes, please list them.
Remove LightningModule.summarize.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃