Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated GPUStatsMonitor callback #12554

Merged
merged 13 commits into from
Apr 10, 2022
Merged

Remove deprecated GPUStatsMonitor callback #12554

merged 13 commits into from
Apr 10, 2022

Conversation

rschireman
Copy link
Contributor

@rschireman rschireman commented Mar 31, 2022

What does this PR do?

Fixes part of #12521 remove pytorch_lightning.callbacks.gpu_stats.GPUStatsMonitor

resolves #9924

Before submitting

  • [x ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • [x ] Did you read the contributor guideline, Pull Request section?
  • [ x] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [x ] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • [ x] Check that all items from Before submitting are resolved
  • [x ] Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

CHANGELOG.md Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 changed the title Remove gpustats monitor Remove deprecated GPUStatsMonitor callback Mar 31, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

pytorch_lightning/callbacks/__init__.py Show resolved Hide resolved
tests/deprecated_api/test_remove_1-7.py Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 requested a review from akihironitta April 1, 2022 07:45
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Apr 2, 2022
@kaushikb11 kaushikb11 enabled auto-merge (squash) April 6, 2022 03:55
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts ready PRs ready to be merged labels Apr 6, 2022
@rschireman
Copy link
Contributor Author

should I remove the tests.helpers.runif.RunIf import in test_remove_1-7.py so the pep8 check works in the pre-commit test?

tests/deprecated_api/test_remove_1-7.py:42: [F401] 'tests.helpers.runif.RunIf' imported but unused

@akihironitta
Copy link
Contributor

should I remove the tests.helpers.runif.RunIf import in test_remove_1-7.py so the pep8 check works in the pre-commit test?

tests/deprecated_api/test_remove_1-7.py:42: [F401] 'tests.helpers.runif.RunIf' imported but unused

@rschireman Yes, please remove the import statement there! Thanks for checking :)

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Apr 10, 2022
@rschireman
Copy link
Contributor Author

@awaelchli Thanks for removing that import! Now the TPU test is failing -- I looked through the output and couldn't find where it failed, only that it failed on deploying to the Kubernetes cluster. I also noticed that my other pull request (#12658) has this issue. Any thoughts?

@kaushikb11 kaushikb11 merged commit 3f0f277 into Lightning-AI:master Apr 10, 2022
@luigicampanaro
Copy link

Hi! Is there anything implementing the functionality of GPUStatsMonitor? I logged DeviceStatsMonitor but I got 125 plots (x2), and I'm not sure any of them is relevant to GPU memory_utilization and gpu_utilization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change callback: device stats callback ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants