-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LightningDataModule.load_from_checkpoint
to load datamodules directly from checkpoint
#12550
Conversation
…DataModules directly from checkpoint
LightningDataModule.load_from_checkpoint
to load datamodules directly from checkpoint
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice feature addition!
I have one concern question where I believe we should look for a decision before merging the PR.
In #10375 I propose to deprecate support for saving and restoring from a singular hparams container passed as input argument. If we decide to do this deprecation in this release, it would be better if the implementation here would already adopt the new restricted (simpler) way of parsing the args. If you think this is less convenient, then I'm also good with this. I just want to avoid us introducing a new feature with a broader scope and immediately deprecate partial functionality.
cc @carmocca
let's do it in this release in a follow-up. I have seen similar issues related to it on slack so would be worth restricting the containers here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
What does this PR do?
Fixes #12062
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @carmocca @awaelchli @Borda @ananthsub @ninginthecloud @jjenniferdai @rohitgr7