-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated prepare_data_per_node
in Trainer
#12536
Merged
Borda
merged 17 commits into
Lightning-AI:master
from
yhl48:prepare_data_per_node_removal
Apr 2, 2022
Merged
Remove deprecated prepare_data_per_node
in Trainer
#12536
Borda
merged 17 commits into
Lightning-AI:master
from
yhl48:prepare_data_per_node_removal
Apr 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
krshrimali
added
refactor
breaking change
Includes a breaking change
deprecation
Includes a deprecation
labels
Mar 31, 2022
44 tasks
krshrimali
changed the title
Remove prepare_data_per_node in trainer
Remove deprecated prepare_data_per_node in trainer
Mar 31, 2022
krshrimali
changed the title
Remove deprecated prepare_data_per_node in trainer
Remove deprecated Mar 31, 2022
prepare_data_per_node
in Trainer
Not sure if the doc here needs changing? Would appreciate any advice here, thanks. |
yhl48
requested review from
williamFalcon,
tchaton,
awaelchli,
SeanNaren,
carmocca,
Borda,
edenlightning and
justusschock
as code owners
March 31, 2022 16:31
Borda
approved these changes
Mar 31, 2022
this should be good:
since there is already a reference for it right below :) |
rohitgr7
approved these changes
Mar 31, 2022
kaushikb11
reviewed
Mar 31, 2022
kaushikb11
approved these changes
Mar 31, 2022
ananthsub
approved these changes
Mar 31, 2022
Co-authored-by: ananthsub <[email protected]>
akihironitta
approved these changes
Apr 1, 2022
carmocca
approved these changes
Apr 1, 2022
awaelchli
approved these changes
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #12521
resolves #8958
Does your PR introduce any breaking changes? If yes, please list them.
Remove deprecated prepare_data_per_node in Trainer
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃